<p>STOP! TESTING-Only! <br>
Do not merge this pull request until all versions of this pull request have been tested. </p>
<p>Per Luci-Commotion issue_30 all pull requests against the Commotion-Lua-Helpers implementation must be tested and approved before any can be merged. </p>
<p>Once you have tested and approved the changes within this pull request report this branch tested and ready for the pull request to be accepted here: <a href="https://github.com/opentechinstitute/luci-commotion/issues/30" class="issue-link" title="Modularize Commotion Helpers">opentechinstitute/luci-commotion#30</a></p>
<p>Thanks!</p>
<hr>
<h4>You can merge this Pull Request by running</h4>
<pre> git pull https://github.com/opentechinstitute/luci-commotion-quickstart issue_30</pre>
<p>Or view, comment on, or merge it at:</p>
<p> <a href='https://github.com/opentechinstitute/luci-commotion-quickstart/pull/53'>https://github.com/opentechinstitute/luci-commotion-quickstart/pull/53</a></p>
<h4>Commit Summary</h4>
<ul>
<li>updated ssl_cert_fingerprints function to point to new modularized commotion helpers library</li>
<li>replaced calls to log with new calls to the current log function in commotions debugger helper module</li>
<li>replaced calls to is_hostname with new calls to the current is_hostname function in commotions identify helper module</li>
<li>removed depreciated patch that also has commotion helpers requirement and corresponding depreciated line in quickstart config.</li>
<li>added back in accidental deletions in code cleanup for commotion_helpers module</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/opentechinstitute/luci-commotion-quickstart/pull/53/files#diff-0">etc/config/quickstart</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/opentechinstitute/luci-commotion-quickstart/pull/53/files#diff-1">usr/lib/lua/luci/controller/QS/QS.lua</a>
(71)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/opentechinstitute/luci-commotion-quickstart/pull/53/files#diff-2">usr/lib/lua/luci/controller/QS/buttons.lua</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/opentechinstitute/luci-commotion-quickstart/pull/53/files#diff-3">usr/lib/lua/luci/controller/QS/modules.lua</a>
(106)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/opentechinstitute/luci-commotion-quickstart/pull/53/files#diff-4">usr/lib/lua/luci/view/QS/module/cert.htm</a>
(4)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/opentechinstitute/luci-commotion-quickstart/pull/53/files#diff-5">usr/share/commotion/patches/apps_controller.qs.patch</a>
(32)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/opentechinstitute/luci-commotion-quickstart/pull/53.patch'>https://github.com/opentechinstitute/luci-commotion-quickstart/pull/53.patch</a></li>
<li><a href='https://github.com/opentechinstitute/luci-commotion-quickstart/pull/53.diff'>https://github.com/opentechinstitute/luci-commotion-quickstart/pull/53.diff</a></li>
</ul>