<p>In <a href="https://github.com/opentechinstitute/mlab-observatory/pull/35#discussion-diff-22615737">convert_from_telescope/observatory_file_writer.py</a>:</p>
<pre style='color:#555'>>      for date, values in hourly_items:
>        values['month'] = date.month
>        values['hour'] = date.hour
>        values['year'] = date.year
> -    fields = ['month', 'hour', 'year',]
> -    fields.extend(self._metric_field_names)
> +      for field_name in sorted(values.keys()):
</pre>
<p>Why not have this be a set and simply take the union of field and values keys?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/opentechinstitute/mlab-observatory/pull/35/files#r22615737">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AC7qBKBNlEK-T7s4AQe6bOCPE_DSGZc-ks5nfZcPgaJpZM4DPjw7.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
  <div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
    <link itemprop="url" href="https://github.com/opentechinstitute/mlab-observatory/pull/35/files#r22615737"></link>
    <meta itemprop="name" content="View Pull Request"></meta>
  </div>
  <meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>