<p>This pull request fixes bridging again, to account for the fact that netifd now seems to send events when an interface is physically plugged or unplugged. Incidentally, this makes it so in the default 'auto' mode, the ethernet interface will attempt to detect whether it is a gateway every time the interface is plugged in, not just when the node is booted.</p>

<p>Also contains some much needed some much-needed cleanup of egregious indentation in the protocol handler script.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/opentechinstitute/commotiond/pull/131'>https://github.com/opentechinstitute/commotiond/pull/131</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix bridge auto detection, massively clean up indentation in protocol handler script.</li>
  <li>Rename set_ and unset_bridge functions to more general add_ and remove_device.</li>
  <li>Turn down default DHCP timeout, add configurable number of DHCP attempts.</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/opentechinstitute/commotiond/pull/131/files#diff-0">openwrt/etc/config/commotiond</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/opentechinstitute/commotiond/pull/131/files#diff-1">openwrt/lib/functions/commotion.sh</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/opentechinstitute/commotiond/pull/131/files#diff-2">openwrt/lib/netifd/proto/commotion.sh</a>
    (232)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/opentechinstitute/commotiond/pull/131.patch'>https://github.com/opentechinstitute/commotiond/pull/131.patch</a></li>
  <li><a href='https://github.com/opentechinstitute/commotiond/pull/131.diff'>https://github.com/opentechinstitute/commotiond/pull/131.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/opentechinstitute/commotiond/pull/131">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AC7qBJ79Pr1ZiwmwmrpbaoL6PMySZXZ-ks5oQK0UgaJpZM4E4zP4.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
  <div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
    <link itemprop="url" href="https://github.com/opentechinstitute/commotiond/pull/131"></link>
    <meta itemprop="name" content="View Pull Request"></meta>
  </div>
  <meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>