[CUWiN-Dev] nodeinfo build error

[Chase Phillips]

Bryan, Jeff, or Dave will need to confirm, but there appears to be
misuse of the adler pointer in nc_update_adler.  Is there only one
call to nc_update_adler -- only from nodeconfig_read_cuw_conf?

It appears in nodeconfig.c's current state, fingerprint should just be
set to NULL at declaration, and someone should shed light on what
circumstances the newly created fingerprint uint32_t would take on a
value other than what the compiler gives it.  (E.g. does Linux zero
out variable memory at declaration?)

Chase

On 7/14/06, Bill Comisky <bcomisky at pobox.com> wrote:
> I get the same output as Dan on the linux crossbuild.
>
> Bill
>
> --
> Bill Comisky
> bcomisky at pobox.com
>
> On 7/14/06, dan blah <dan.blah at gmail.com> wrote:
> > putting #include <string.h> in nodeinfo.c seems to fix that... then i get
> >
> > #   compile  nodeconfig/nodeconfig.o
> > /u4/blah/cuwin/scratch/T/bin/i386--netbsdelf-gcc -O2   -Werror
> > -I/u4/blah/cuwin/cuw-trunk/src/boot-image/./../../extern-src/clearsilver
> > -I/u4/blah/cuwin/cuw-trunk/src/nodeconfig/../
> > -I/u4/blah/cuwin/cuw-trunk/src/nodeconfig/../libnodeinfo -Wall
> > -std=c99 -fPIC -g -Wno-traditional  -nostdinc -isystem
> > /u4/blah/cuwin/scratch/i386/D/usr/include  -c
> > /u4/blah/cuwin/cuw-trunk/src/nodeconfig/nodeconfig.c
> > cc1: warnings being treated as errors
> > /u4/blah/cuwin/cuw-trunk/src/nodeconfig/nodeconfig.c: In function
> > 'nodeconfig_read_cuw_conf':
> > /u4/blah/cuwin/cuw-trunk/src/nodeconfig/nodeconfig.c:615: warning:
> > 'fingerprint' may be used uninitialized in this function
> >
> > *** Failed target:  nodeconfig.o
> > *** Failed command: /u4/blah/cuwin/scratch/T/bin/i386--netbsdelf-gcc
> > -O2 -Werror -I/u4/blah/cuwin/cuw-trunk/src/boot-image/./../../extern-src/clearsilver
> > -I/u4/blah/cuwin/cuw-trunk/src/nodeconfig/../
> > -I/u4/blah/cuwin/cuw-trunk/src/nodeconfig/../libnodeinfo -Wall
> > -std=c99 -fPIC -g -Wno-traditional -nostdinc -isystem
> > /u4/blah/cuwin/scratch/i386/D/usr/include -c
> > /u4/blah/cuwin/cuw-trunk/src/nodeconfig/nodeconfig.c
> > *** Error code 1
> >
> > Stop.
> > nbmake: stopped in /u4/blah/cuwin/cuw-trunk/src/nodeconfig
> >
> > *** Failed target:  all-nodeconfig
> > *** Failed command: _makedirtarget() { dir="$1"; shift; target="$1";
> > shift; case "${dir}" in /*) this="${dir}/"; real="${dir}" ;; .)
> > this=""; real="/u4/blah/cuwin/cuw-trunk/src" ;; *) this="${dir}/";
> > real="/u4/blah/cuwin/cuw-trunk/src/${dir}" ;; esac; show=${this:-.};
> > echo "${target} ===> ${show%/}${1:+ (with: $@)}"; cd "${real}" &&
> > /u4/blah/cuwin/scratch/T/bin/nbmake _THISDIR_="${this}" "$@"
> > ${target}; }; _makedirtarget nodeconfig all
> > *** Error code 1
> >
> > Stop.
> > nbmake: stopped in /u4/blah/cuwin/cuw-trunk/src
> >
> >
> > On 7/14/06, dan blah <dan.blah at gmail.com> wrote:
> > > same happened building on cuw.
> > > On 7/13/06, Bryan Cribbs <bryan at ojctech.com> wrote:
> > > >
> > > > On Jul 13, 2006, at 11:23 AM, David Young wrote:
> > > >
> > > > > On Thu, Jul 13, 2006 at 09:39:47AM -0500, Bill Comisky wrote:
> > > > >>
> > > > >> On a linux crossbuild using trunk rev4081, see below. I don't know
> > > > >> if the
> > > > >> 'cc1: warnings being treated as errors' is a setting I can/should
> > > > >> change..
> > > > >> maybe specific to my crossbuild environment?
> > > > >
> > > > > Treating warnings as errors is desirable.  We are aiming for zero
> > > > > warnings.
> > > > >
> > > > > Looks like nodeinfo.c needs to #include <string.h>.
> > > > >
> > > > > Dave
> > > >
> > > > Bill, can you let me know if #include <string.h> fixes the crossbuild
> > > > without NOGCCERROR=1?
> > > >
> > > >
> > > >
> > > > _______________________________________________
> > > > CU-Wireless-Dev mailing list
> > > > CU-Wireless-Dev at lists.cuwireless.net
> > > > http://lists.chambana.net/cgi-bin/listinfo/cu-wireless-dev
> > > >
> > >
> > >
> > > --
> > > Daniel
> > >
> >
> >
> > --
> > Daniel
> > _______________________________________________
> > CU-Wireless-Dev mailing list
> > CU-Wireless-Dev at lists.cuwireless.net
> > http://lists.chambana.net/cgi-bin/listinfo/cu-wireless-dev
> >
> >
> _______________________________________________
> CU-Wireless-Dev mailing list
> CU-Wireless-Dev at lists.cuwireless.net
> http://lists.chambana.net/cgi-bin/listinfo/cu-wireless-dev
>