[Commotion-admin] [luci-commotion-apps] fixed some bugs with app icons; removed extraneous files (#40)

Dan Staples notifications at github.com
Mon Dec 9 19:25:43 UTC 2013


this fixes a few things:

1. the default app icons were SVGs, which don't render in some older browsers (notably <= IE 8). This changes them to PNGs.
2. the icons in the picker would be highlighted black when hovered over, which would make them totally black due to icon transparency. This changes the highlight color to a light pink in line with our color scheme.
3. 'http://' and the 'thisnode' alias were prepended to each app icon path unnecessarily. This removes that, and has the benefit of not breaking if we decided to change the name of our alias in the future.
4. Removed lots of extraneous files in the /luci-static directory.

To test:
1. on the create app page, and mouse hover over the default icons
2. choose one of the icons, and submit the app. make sure it shows up correctly on the listing.
3. Edit the app, and change the icon to be an external image on the internet. Make sure it shows up correctly on the listing page (might need to get splashed so it allows external requests).
You can merge this Pull Request by running:

  git pull https://github.com/opentechinstitute/luci-commotion-apps app-icon-fixes

Or you can view, comment on it, or merge it online at:

  https://github.com/opentechinstitute/luci-commotion-apps/pull/40

-- Commit Summary --

  * fixed some bugs with app icons; removed extraneous files

-- File Changes --

    M lua/luci/view/commotion/apps_form.htm (22)
    M lua/luci/view/themes/commotion/apps_apps.htm (2)
    D luci-static/commotion/add_banner (1)
    D luci-static/commotion/add_form (13)
    M luci-static/commotion/apps.css (23)
    D luci-static/commotion/apps_apps (4)
    D luci-static/commotion/apps_banner (6)
    D luci-static/commotion/apps_categories (3)
    A luci-static/commotion/audio.png (0)
    D luci-static/commotion/audio.svg (9)
    A luci-static/commotion/calendar.png (0)
    D luci-static/commotion/calendar.svg (51)
    A luci-static/commotion/chat.png (0)
    D luci-static/commotion/chat.svg (147)
    A luci-static/commotion/code.png (0)
    D luci-static/commotion/code.svg (21)
    M luci-static/commotion/commotion-faded2.png (0)
    A luci-static/commotion/downloads.png (0)
    D luci-static/commotion/downloads.svg (82)
    A luci-static/commotion/email.png (0)
    D luci-static/commotion/email.svg (3)
    A luci-static/commotion/internet.png (0)
    D luci-static/commotion/internet.svg (3)
    A luci-static/commotion/photo.png (0)
    D luci-static/commotion/photo.svg (6)
    A luci-static/commotion/radio.png (0)
    D luci-static/commotion/radio.svg (3)
    A luci-static/commotion/write.png (0)
    D luci-static/commotion/write.svg (3)

-- Patch Links --

https://github.com/opentechinstitute/luci-commotion-apps/pull/40.patch
https://github.com/opentechinstitute/luci-commotion-apps/pull/40.diff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20131209/07c01665/attachment-0001.html>


More information about the Commotion-admin mailing list