[Commotion-admin] [luci-commotion] Improved logic of uploader function (#43)

gradyoti notifications at github.com
Fri Nov 1 17:31:37 UTC 2013


Removed unnecessary if condition. Now all uploads are run through the checkFile function, which will catch empty uploads.

To check:
1) Navigate to mesh profile page
2) Click "upload" (do NOT attach a file first)
3) The page should refresh with a warning that says "There does not seem to be a file here"

Rinse and repeat.
You can merge this Pull Request by running:

  git pull https://github.com/opentechinstitute/luci-commotion issue40

Or you can view, comment on it, or merge it online at:

  https://github.com/opentechinstitute/luci-commotion/pull/43

-- Commit Summary --

  * removed unnecessary empty file condition. Now all uploads are run through the check File function, which will catch empty uploads.

-- File Changes --

    M luasrc/controller/commotion/meshprofile.lua (10)

-- Patch Links --

https://github.com/opentechinstitute/luci-commotion/pull/43.patch
https://github.com/opentechinstitute/luci-commotion/pull/43.diff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20131101/b8de65c1/attachment.html>


More information about the Commotion-admin mailing list