[Commotion-admin] [luci-commotion-apps] Commotion-Lua-Helpers (#26)

Seamus Tuohy notifications at github.com
Tue Nov 5 14:29:24 UTC 2013


STOP! TESTING-Only! 
Do not merge this pull request until all versions of this pull request have been tested. 

Per Luci-Commotion issue_30 all pull requests against the Commotion-Lua-Helpers implementation must be tested and approved before any can be merged. 

Once you have tested and approved the changes within this pull request report this branch tested and ready for the pull request to be accepted here: https://github.com/opentechinstitute/luci-commotion/issues/30

Thanks!
You can merge this Pull Request by running:

  git pull https://github.com/opentechinstitute/luci-commotion-apps issue_30

Or you can view, comment on it, or merge it online at:

  https://github.com/opentechinstitute/luci-commotion-apps/pull/26

-- Commit Summary --

  * replaced DIE function from commotion helpers with luci.dispatcher.error500
  * replaced calls to uci_encode with updated uci encofing function from modularized commotion helpers
  * replaced calls to printf with new calls to the current tprintf function in commotions util helper module
  * replaced calls to html_encode with new html function in the encode module
  * replaced call for url_encode with call to url function in updated commotion helper encode module
  * replaced calls to is_ip4addr with new calls to the current is_ip4addr function in commotions identify helper module
  * replaced calls to is_uint with new calls to the current is_uint function in commotions identify helper module
  * replaced calls to is_hex with new calls to the current is_hex function in commotions identify helper module
  * replaced calls to is_port with new calls to the current is_port function in commotions identify helper module
  * replaced calls to commotion helpers table.contains with calls to luci's existing contains function in util.
  * removed call to commotion-helpers which no longer exists

-- File Changes --

    M lua/luci/controller/commotion/apps_controller.lua (97)

-- Patch Links --

https://github.com/opentechinstitute/luci-commotion-apps/pull/26.patch
https://github.com/opentechinstitute/luci-commotion-apps/pull/26.diff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20131105/7160e368/attachment.html>


More information about the Commotion-admin mailing list