[Commotion-admin] [luci-commotion] Issue20 (#41)

[hawkinswnaf]

I watched over @gradyoti 's shoulder while he was doing this testing. It
looks good, but I definitely recommend independent testing.

On 10/29/2013 05:43 PM, gradyoti wrote:
> Added test for name collisions with uploaded profiles, including a
> warning and a prompt to allow the user to overwrite the existing profile
> with the same name.
> 
> To test:
> 1) Upload a profile (for instance, "TEST") (must be valid profile)
> 2) Change one value in the profile (but not the name). Example: ssid was
> "TEST", change it to "TESTover"
> 3) Upload the profile again, you should be prompted with a warning and a
> set of options
> 4) Click "No, I will rename the file and upload later", then "Confirm".
> Check the profile "TEST" in etc/commotion/profiles.d/ to confirm that
> the previous TEST profile was not overwritten
> 5) Upload the profile again, click "Yes, please overwrite the existing
> profile". Check the profile in profiles.d/ to confirm that TEST was in
> fact overwritten with the new ssid value
> 6) After clicking "confirm", you should see the default meshprofile page
> (no warning or overwrite options)
> 
> Serve chilled.
> 
> ------------------------------------------------------------------------
> 
> 
>         You can merge this Pull Request by running
> 
>   git pull https://github.com/opentechinstitute/luci-commotion issue20
> 
> Or view, comment on, or merge it at:
> 
>   https://github.com/opentechinstitute/luci-commotion/pull/41
> 
> 
>         Commit Summary
> 
>   * moved uploaded mesh profiles to tmp before copying to
>     /etc/commotion/profiles.d/ to allow name collision checking
>   * added check for name collisions with extant profiles in
>     /etc/commotion/profiles.d/
>   * added warning to user when a name conflict occurs
>   * added 'radio' button to meshprofile.htm, which is called when passed
>     the variable 'OW' (overwite) from meshprofile.lua
>   * added 'confirm' button. If the user clicks 'yes'->'confirm', the new
>     profile will overwrite the existing one
>   * profile uploader now allows user to decline overwriting the existing
>     profile
> 
> 
>         File Changes
> 
>   * *A* luasrc/controller/commotion/.meshprofile.lua.swp
>     <https://github.com/opentechinstitute/luci-commotion/pull/41/files#diff-0>
>     (0)
>   * *M* luasrc/controller/commotion/meshprofile.lua
>     <https://github.com/opentechinstitute/luci-commotion/pull/41/files#diff-1>
>     (49)
>   * *A* luasrc/controller/commotion/meshprofile.lua~
>     <https://github.com/opentechinstitute/luci-commotion/pull/41/files#diff-2>
>     (347)
>   * *M* luasrc/view/commotion/meshprofile.htm
>     <https://github.com/opentechinstitute/luci-commotion/pull/41/files#diff-3>
>     (10)
> 
> 
>         Patch Links:
> 
>   * https://github.com/opentechinstitute/luci-commotion/pull/41.patch
>   * https://github.com/opentechinstitute/luci-commotion/pull/41.diff
>

---
Reply to this email directly or view it on GitHub:
https://github.com/opentechinstitute/luci-commotion/pull/41#issuecomment-27346406
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20131029/fd37a71d/attachment-0001.html>