[Commotion-admin] [luci-commotion] Reworked quick fqdn check (#22)

areynold notifications at github.com
Thu Sep 12 14:55:43 UTC 2013


Quick check that a submitted fqdn uses valid characters and is less than 255 characters overall. Should still be rewritten to also check that each dot-separated segment is less than 63 characters.

To test, submit 3 domains through luci-commotion-dash: www.commotionwireless.net, www.commotionwireless.net:1337, and www.comm%00tionwireless.net. Only the first should be accepted.
You can merge this Pull Request by running:

  git pull https://github.com/opentechinstitute/luci-commotion is_fqdn

Or you can view, comment on it, or merge it online at:

  https://github.com/opentechinstitute/luci-commotion/pull/22

-- Commit Summary --

  * Added validation for fqdns instead of just hostnames
  * added endpoints to quick fqdn string check

-- File Changes --

    M luasrc/commotion_helpers.lua (15)

-- Patch Links --

https://github.com/opentechinstitute/luci-commotion/pull/22.patch
https://github.com/opentechinstitute/luci-commotion/pull/22.diff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20130912/2f0b2cd0/attachment.html>


More information about the Commotion-admin mailing list