[Commotion-admin] [mlab-observatory] Adding sample checking module, Telescope data parser (#29)

[mtlynch]

> +  def add_to_counts(self, metadata, results):
> +    """Add result data to overall sample counts.
> +
> +    Args:
> +      metadata: (dict) A dictionary of metadata describing the results data.
> +        Currently the only supported value for the 'metric' key is
> +        'download_throughput'.
> +
> +      results: (list) A list of (datetime, value) pairs representing Telescope
> +        results for the given metadata.
> +
> +    Raises:
> +      ValueError: If the metadata parameter does not specify
> +        'download_throughput' as the value of the 'metric' key.
> +    """
> +    if metadata['metric_name'] != 'download_throughput':

Hmm, the problem is that if we take out this check here, we have to maintain counts per metric. Otherwise if the caller doesn't know they have to only pass in download_throughput, the results for all metrics get added together, which we don't want.

Then we have the issue that when the caller calls `blacklister.is_blacklisted('lga01-comcast-upload_throughput...')` something in the stack has to do something like:

```
# Workaround until Observatory supports omitting datasets on a per-metric basis
if metadata['metric_name' != 'download_throughput':
  metatadata['metric_name'] = `download_throughput`
```

Actually, now that I write that out, it doesn't seem so bad. The hacky workaround stuff could be contained at a high level in `DataFileBlacklister` rather than way down in `SampleCounter`. I'll do it!

---
Reply to this email directly or view it on GitHub:
https://github.com/opentechinstitute/mlab-observatory/pull/29/files#r21614793
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20141210/dd1ffcbc/attachment-0001.html>