[Commotion-admin] [commotiond] return value of recv should be ssize_t (#86)

Dan Staples notifications at github.com
Wed Feb 5 21:49:27 UTC 2014


reqlen should be ssize_t (signed), not size_t (unsigned). daemon.c:722 checks if reqlen < 0, which currently can never be true.
You can merge this Pull Request by running:

  git pull https://github.com/opentechinstitute/commotiond ssize_t

Or you can view, comment on it, or merge it online at:

  https://github.com/opentechinstitute/commotiond/pull/86

-- Commit Summary --

  * Fix names of IP generation config options in daemon.c.
  * Fix debug statements that use incorrect variable names.
  * moved pthread to end of link order
  * recv returns an ssize_t value, which is signed

-- File Changes --

    M src/daemon.c (6)
    M src/iface.c (4)
    M tests/CMakeLists.txt (3)

-- Patch Links --

https://github.com/opentechinstitute/commotiond/pull/86.patch
https://github.com/opentechinstitute/commotiond/pull/86.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/opentechinstitute/commotiond/pull/86
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20140205/568e0b0c/attachment.html>


More information about the Commotion-admin mailing list