[Commotion-admin] [commotiond] Fix freeing of response objects in client API (#92)

Josh King notifications at github.com
Fri Feb 21 19:02:38 UTC 2014


This commit simple adds an hattach() call to the co_free() function in the client API. This explicitly detaches the object that is being freed from the memory pool. Otherwise, it will not be freed with this call and will not be until the API is shut down.

To test, there should not be any obvious change of functionality from this simple fix. You should just verify that interactive client commands still work properly, and that the client does not bomb out (the commotion CLI client uses this API to free responses when in interactive mode).
You can merge this Pull Request by running:

  git pull https://github.com/opentechinstitute/commotiond api-free

Or you can view, comment on it, or merge it online at:

  https://github.com/opentechinstitute/commotiond/pull/92

-- Commit Summary --

  * Made calls to the client API co_free() function explicitly detach object from memory pool so that it would actually be freed.
  * Ensure that the client is free request and response objects while in interactive mode.

-- File Changes --

    M src/client.c (2)
    M src/commotion.c (1)

-- Patch Links --

https://github.com/opentechinstitute/commotiond/pull/92.patch
https://github.com/opentechinstitute/commotiond/pull/92.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/opentechinstitute/commotiond/pull/92
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20140221/ccc06efb/attachment.html>


More information about the Commotion-admin mailing list