[Commotion-admin] [luci-commotion] Fix for Issue 143. Secondary check to ensure setup wizard is disabled. (#169)

[Seamus Tuohy]

Modified the root level node that the login page redirects to. It is now a function that first checks for, and if on removes, the setup wizard flag. After the check the function then redirects to the default status page.
https://github.com/opentechinstitute/luci-commotion/issues/143

Testing Instructions for this pull request. 

Test #1
* Flash a router with this branch of luci-commotion
* During setup wizard, at any point, click on the advanced button in the footer
* Once logged in, there should be a "basic configuration" side menu.
* If the basic config menu is missing then the patch did not work.

Test #2
* Reflash router to its default state (Or just change the enabled flag in /etc/config/setup_wizard to "1"
* Complete the setup wizard. 
* When the node is running its "applying" animation click the finish button as soon as possible.
* This will skip the old setup wizard check and take you to the login page. 
* Once logged in, there should be a "basic configuration" side menu.
* If the basic config menu is missing then the patch did not work.

You can merge this Pull Request by running:

  git pull https://github.com/opentechinstitute/luci-commotion issue_143

Or you can view, comment on it, or merge it online at:

  https://github.com/opentechinstitute/luci-commotion/pull/169

-- Commit Summary --

  * Modified the root level redirect from the login page to a function that first checks for, and if on removes, the setup wizard flag, and then redirects to the default status page.

-- File Changes --

    M luasrc/controller/commotion/basic_config.lua (19)

-- Patch Links --

https://github.com/opentechinstitute/luci-commotion/pull/169.patch
https://github.com/opentechinstitute/luci-commotion/pull/169.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/opentechinstitute/luci-commotion/pull/169
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20140221/fb26c140/attachment.html>