[Commotion-admin] [luci-commotion] Moves system level setting of the hostname to the "apply" stage of luci value settings (#188)

Seamus Tuohy notifications at github.com
Wed Mar 5 16:28:49 UTC 2014


Per Issue #180 this pull request modifies the way hostnames are added to the system by pushing all system-level manipulation of the hostname into a init.d script. 

To Test: 
1) Flash a node with this branch included
2) Connect to node and click "setup wizard"
3) Change the host-name to one of your choosing on the first page
4) On the next page the hostname field in the header should still read "commotion"
5) On the "Save and Apply" page click the "Start Over" button
6) If the hostname changes should now be reverted 
7) Add a new hostname
8) On the "Save and Apply" page click the "Save and Apply" button
9) Log into the administration menu
10) In the header should state the new hostname you added as your hostname.

5) When you are brought back to the original page, the hostname will still be set on the node
You can merge this Pull Request by running:

  git pull https://github.com/opentechinstitute/luci-commotion issue_180

Or you can view, comment on it, or merge it online at:

  https://github.com/opentechinstitute/luci-commotion/pull/188

-- Commit Summary --

  * modified hostname to use uci-track instead of setting itself in proc/.../hostname immediately so that a setup-wizard user will not immediately have their changes set.
  * fixed uci calls and removed calls to sys on page load.

-- File Changes --

    A files/etc/init.d/hostname (18)
    M files/etc/uci-defaults/luci-setup-wizard (3)
    M luasrc/model/cbi/commotion/basic_ns.lua (1)

-- Patch Links --

https://github.com/opentechinstitute/luci-commotion/pull/188.patch
https://github.com/opentechinstitute/luci-commotion/pull/188.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/opentechinstitute/luci-commotion/pull/188
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20140305/04d55b59/attachment.html>


More information about the Commotion-admin mailing list