[Commotion-admin] [commotion-dashboard-helper] Fixed validation error in bigboard config form (#17)
areynold
notifications at github.com
Thu Mar 6 18:07:21 UTC 2014
Closes #16
Was expecting wrong validation response in L82 of bigboard-conf.lua.
Also cleaned up duplicate debugger import and log statements.
To test,
1. Enable bigboard send (Advanced > BigBoard Configuration) and enter a hostname or IP address in the form field. The form should save with no errors.
2. Enter an invalid hostname/IP address. Save should reject with an error.
3. Disable bigboard and save, then re-enable. The form field should read "x.x.x.x"
You can merge this Pull Request by running:
git pull https://github.com/opentechinstitute/commotion-dashboard-helper input-validation
Or you can view, comment on it, or merge it online at:
https://github.com/opentechinstitute/commotion-dashboard-helper/pull/17
-- Commit Summary --
* Expected wrong return value on validate
* Cleaned up logger import
-- File Changes --
M luasrc/controller/commotion-dash/bigboard-conf.lua (15)
-- Patch Links --
https://github.com/opentechinstitute/commotion-dashboard-helper/pull/17.patch
https://github.com/opentechinstitute/commotion-dashboard-helper/pull/17.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/opentechinstitute/commotion-dashboard-helper/pull/17
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20140306/f1b31164/attachment.html>
More information about the Commotion-admin
mailing list