[Commotion-admin] [luci-commotion] Client Controls Fixes (#194)

[areynold]

Replaces #185.

Fixes #184, #189 

To test:
1. In your browser, go to Admin > Client Controls and change the Time Until Welcome Page is Shown to 1 hour.
2. "Seconds" should not be an available option.
3. Click Save, then Save & Apply.
4. SSH in and run `ndsctl status`. If you see actual nodogsplash data, the fix worked. If the fix didn't work you will see `ndsctl: nodogsplash probably not started (Error: Connection refused)`.
5. Open /etc/nodogsplash/nodogsplash.conf. ClientIdleTimeout and ClientForceTimeout should each be set to 60.
6. In your browser, set Time Until Welcome Page to 1 day. ClientIdleTimeout/ClientForceTimeout should be 1440.
You can merge this Pull Request by running:

  git pull https://github.com/opentechinstitute/luci-commotion time-fix

Or you can view, comment on it, or merge it online at:

  https://github.com/opentechinstitute/luci-commotion/pull/194

-- Commit Summary --

  * removed return statements from init calls
  * Swapped calculations for hours and days
  * Removed unused seconds value

-- File Changes --

    M files/etc/init.d/ucidog (12)
    M luasrc/model/cbi/commotion/client_wp.lua (1)

-- Patch Links --

https://github.com/opentechinstitute/luci-commotion/pull/194.patch
https://github.com/opentechinstitute/luci-commotion/pull/194.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/opentechinstitute/luci-commotion/pull/194
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20140306/a09a1d4d/attachment.html>