[Commotion-admin] [commotion-client] Split single app (#16)

Seamus Tuohy notifications at github.com
Tue Mar 11 18:01:05 UTC 2014


This branch was focused on encapsulation and code cleanup on the commotion client to prepare it for easy modification by later developers. 
You can merge this Pull Request by running:

  git pull https://github.com/opentechinstitute/commotion-client split_single_app

Or you can view, comment on it, or merge it online at:

  https://github.com/opentechinstitute/commotion-client/pull/16

-- Commit Summary --

  * Moved ui GUI objects into ui folder within GUI directory to remove clutter.c
  * Created a restart window object to avoid a full close of the application when a restart closes all other windows.
  * Made GUI module imports not attempt to import classes, and instead import the module and then call the classes as needed.
  * Added a default exit_on_close value to avoid errors where it is checked before being called.
  * added a generic thread class and extended it to allow for the application to keep its state during a restart and therefore not shutdown when all its windows are removed.
  * removed the graphical restart window in favor of a simple thread.
  * seperated the system tray and the main window in the commotion client
  * seperated the system tray from the main window
  * Changed old signal events to new style and moved them to application control functions.
  * see: last commit but re: main application code
  * added exceptions to system tray start and init functions
  * removed empty extension file from last commit
  * got system tray connected and working correctly with the main window
  * split out the single applicaiton classes from the main commotion_client code file
  * implemented a close function for the system tray to ensure that it is fully cleaned up for the restart.
  * fixing whitespace
  * Added an exit function and replaced all existing sys.exit functions with it.
  * Replaced sys.exit in critical error functions with QApplication.exit which will pass the error message to sys.exit after its clean up anyway.
  * Made ending the restart thread more indirect
  * Made main window called more indirectly and gathered main window functions together in the application.
  * organized the code to make it more readable
  * added a clean up function to the main window to allow proper clean up without forcing other parts of the application to know how to do it properly for this object

-- File Changes --

    M commotion_client/GUI/crash_report.py (2)
    M commotion_client/GUI/main_window.py (57)
    A commotion_client/GUI/system_tray.py (37)
    R commotion_client/GUI/ui/crash_report_window.ui (0)
    M commotion_client/assets/commotion_assets.qrc (2)
    A commotion_client/assets/images/loading62.gif (0)
    M commotion_client/commotion_client.py (360)
    A commotion_client/data/extensions/test_ext001.conf (8)
    A commotion_client/tests.py (0)
    A commotion_client/tests/__init__.py (0)
    A commotion_client/tests/extensions/__init__.py (0)
    A commotion_client/tests/extensions/test_ext001/mainWin.ui (35)
    A commotion_client/tests/extensions/test_ext001/myMain.py (32)
    A commotion_client/tests/extensions/test_ext001/warning001.ui (84)
    A commotion_client/tests/test_util_config.py (40)
    A commotion_client/utils/single_application.py (113)
    A commotion_client/utils/thread.py (30)

-- Patch Links --

https://github.com/opentechinstitute/commotion-client/pull/16.patch
https://github.com/opentechinstitute/commotion-client/pull/16.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/opentechinstitute/commotion-client/pull/16
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20140311/72cb98cb/attachment-0001.html>


More information about the Commotion-admin mailing list