[Commotion-admin] [luci-commotion] Slightly refactor 'Additional Network Interfaces' page. (#461)

[Josh King]

This is a refactoring of the 'Additional Network Interfaces' page in the basic menu. It allows a user to control the gateway ethernet port's DHCP settings, as well as optionally provide a static IP configuration. It also controls whether a present gateway is advertised to the rest of the mesh, and exposes the ability to mesh over ethernet in two circumstances:

* When we are attempting to receive an IP address via DHCP.
* When we have statically assigned IP information.

We don't provide it in circumstances where there is or may be an HNA client network on the ethernet interface, because OLSR does not permit the same interface to be both mesh and an HNA. There are edge cases that aren't covered, but trying to support them would both take significant revisions and result in potentially unexpected behavior.

To test:
* Go to the additional network interfaces page, and test that all of the DHCP options work.
* In the two cases where mesh-over-ethernet is supported, test to make sure you can mesh with another node over the ethernet interface.
You can view, comment on, or merge this pull request online at:

  https://github.com/opentechinstitute/luci-commotion/pull/461

-- Commit Summary --

  * Slightly refactor 'Additional Network Interfaces' page.

-- File Changes --

    M luasrc/model/cbi/commotion/basic_ani.lua (81)

-- Patch Links --

https://github.com/opentechinstitute/luci-commotion/pull/461.patch
https://github.com/opentechinstitute/luci-commotion/pull/461.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/opentechinstitute/luci-commotion/pull/461
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20150325/53ab25d8/attachment.html>