[CUWiN-Dev] reimport quagga? anyone? bueller? :-)

[Bill Comisky]

On Tue, 16 May 2006, Bill Comisky wrote:

> On Sat, 13 May 2006, David Young wrote:
>
>>  Ok, so CUWiN have astonishingly high Coverity "defect" rate, owing mostly
>>  to the 3rd-party sources in our tree, especially Quagga and Clearsilver.
>>  What is more important is that some of the "defects" in Quagga may be
>>  quite real, affecting the reliability of CUWiN routers in the field.
>>
>>  We are running an oldish Quagga by now.  I imagine that if we reimported,
>>  the number of defects would plummet.  Here's the problem, though: Quagga
>>  changed its socket ABI, which we use for the hslsd<->zebra communication,
>>  since we last imported it.  This makes a reimport too daunting at my
>>  current level of busy-ness.
>>
>>  The ABI changes were discussed on the Quagga developer's list, and they
>>  will probably stand out in an svn diff after re-importing Quagga on the
>>  vendor branch.  The changes to hslsd will be limited to tweaking the zrib
>>  library.  It may be an afternoon's work.  It will be important to test.
>
> I had a little time so I went ahead with the first steps and imported and 
> tagged Quagga 0.99.4.  Changes haven't been merged to the extern-src/quagga 
> yet.. which maybe should be done on a branch and not trunk?  If I get time 
> I'll take a look at merging and making the zrib changes (though if someone 
> wants to jump in, go for it).
>
> Bill
>

I created a quagga-zrib-update branch and merged the 0.99.2 -> 0.99.4 
changes from the vendor branch to extern-src/quagga.  I made the changes I 
thought necessary in src/zrib to accomodate the changes in the zebra 
packet header and the interface flags (see commit logs for details). 
However, I haven't tested anything yet other than compiling it.

Any help in testing (or fixes/improvements to my changes) is appreciated.

Bill

--
Bill Comisky
bcomisky at pobox.com