[Commotion-admin] [commotion-mesh-applet] Merge Decompose branch back into Master (#17)

[technosopher]

This pull request overhauls commotion-mesh-applet to leverage the new commotionc core "library", which now contains all essential functions needed to establish a commotion network. Commotion-mesh-applet now serves as ONLY a frontend for other Commotion functions, including those automatically invoked by nm-dispatcher-olsrd.  This pull request therefore depends on opentechinstitute/commotion-linux-py at f37ed66 and https://github.com/opentechinstitute/nm-dispatcher-olsrd/commit/ce35103ddf5890cd000d76168eb786460b7ce3da

Fixes issue #4 , #6 , #7 , #16 ; Partially addresses #9 , #12 

Fixes https://github.com/opentechinstitute/commotion-linux-py/issues/1, https://github.com/opentechinstitute/commotion-linux-py/issues/8

To test this pull request, all of the following steps must be done for our three supported platforms (Ubuntu 12.04 or later, Ubuntu 11.10 or earlier, and Debian testing):

-  Install the commotion-linux-py, olsrd, python-networkmanager, and commotion-wpasupplicant debian packages from downloads.commotionwireless.net/linux with dpkg -i
-  On debian, recompile and reinstall the wpasupplicant package with CONFIG_IBSS_RSN=y set in /debian/config/linux. (To do this, apt-get source wpasupplicant, make the change, then dpkg-buildpackage -rfakeroot -uc -b in the root of the extracted source package, and the dpkg -i the newly-rebuilt package)
- Log in and log out of a user session to confirm that the applet loads automatically.
- Test all menu entries.  Confirm that a signal-strength icon shows up next to any profile that is compatible with an active mesh.  Edit a network profile using the built-in vi-based editor.  Connect to a mesh using the applet menu, and confirm that all mesh status menu options are (a) available, and (b) produce useful information.  
- Check /var/log/syslog to confirm that there are log messages coming in from commotion-mesh-applet.  


KNOWN BUGS:
- Even though olsrd is running properly, it may sometimes fail to get routes when operating in the context of an encrypted mesh. This bug may be in upstream; in any case, it is beyond the scope of this pull request.  If you run into problems testing the applet with an encrypted mesh, try using an unencrypted one.  
- The check for IBSS_RSN compatibility doesn't work for debian testing (hence the need to preemptively recompile wpasupplicant on debian).  There is a partial fix in commotion-linux-py's postinst script; watch closely to see if the check fails when installing on debian (which it should)

You can merge this Pull Request by running:

  git pull https://github.com/opentechinstitute/commotion-mesh-applet decompose

Or you can view, comment on it, or merge it online at:

  https://github.com/opentechinstitute/commotion-mesh-applet/pull/17

-- Commit Summary --

  * Added skeleton of fallback system for OSes with old versions of wpa_supplicant
  * Added support functions for fallback system, adapted from nm-dispatcher-olsrd functions that should probably be put in a common library
  * Fixed typos, finished full implementation of fallback init, and reintegrated the fallback routine into applet_support.py
  * Fixed several minor but show-stopping bugs, and added missing line to kill wpa_supplicant.
  * Completed full fallback routine, and added exit routine to kill wpa_supplicant and olsrd when the applet exits
  * Decomposed fallback routine in preparation for moving it to another file; added robust disconnect routine and associated menu item
  * Fixed tiny typo
  * Rewired code to use new commotionc module functions; removed redundant functions that now live in the aforementioned module
  * Fixed very incorrect subprocess call that invokes the fallback routine
  * Debugged icon display logic, which was failing due to several bugs in connection parsing and comparison routines
  * Replaced erroneous subprocess call causing applet to become unresponsive after connecting + a bug causing applet crash when not connected
  * Fixed typo
  * Rewired calls to fallback script to support up/down logic, so as to reduce the # of gksu password prompts
  * Added commotion-linux dependency; full path for wpa_supplicant call
  * Overhauled logging such that all output is now routed through commotionc, and deposited in one central location
  * Added menu option for editing network profiles, backed by gksudo call to vim
  * Added context-aware menu items for fns that should only be available when connected to mesh; fixed bug in position of commotionc init

-- File Changes --

    M .gitignore (2)
    M commotion_applet_support.py (109)
    M debian/control (1)

-- Patch Links --

https://github.com/opentechinstitute/commotion-mesh-applet/pull/17.patch
https://github.com/opentechinstitute/commotion-mesh-applet/pull/17.diff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20131104/7689ce23/attachment-0001.html>