[Commotion-admin] [luci-commotion] Dns override (#109)
areynold
notifications at github.com
Wed Nov 20 20:56:58 UTC 2013
Addresses #33
Users should be able to override profile dns entries.
To test:
1. Select Commotion > Mesh Configuration (manual) from the top menu
2. Add two ip addresses in the DNS Servers field and save & apply. When the page reloads, the field should contain both ip addresses, and changes should appear in /etc/config/network on all interfaces using proto commotion.
3. Delete the ip addresses from the DNS Servers field in meshconfig. The dns entry should be removed from all interfaces in /etc/config/network with proto commotion.
4. Enter an invalid (non-ip address) string. The changes should be rejected.
You can merge this Pull Request by running:
git pull https://github.com/opentechinstitute/luci-commotion dns-override
Or you can view, comment on it, or merge it online at:
https://github.com/opentechinstitute/luci-commotion/pull/109
-- Commit Summary --
* Deleted .swp and gedit backup files
* Working placeholder population from /etc/config/network
* Successful validation using host datatype
* DNS form field should only show unique entries
* Use .default, not .placeholder so overrides aren't accidentally deleted when editing other sections
-- File Changes --
D luasrc/controller/commotion/.meshprofile.lua.swp (0)
D luasrc/controller/commotion/meshprofile.lua~ (347)
M luasrc/model/cbi/commotion/meshconfig.lua (69)
-- Patch Links --
https://github.com/opentechinstitute/luci-commotion/pull/109.patch
https://github.com/opentechinstitute/luci-commotion/pull/109.diff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20131120/81e6cf0a/attachment.html>
More information about the Commotion-admin
mailing list