[Commotion-admin] [luci-commotion-apps] Add application form fixes (#36)

Dan Staples notifications at github.com
Thu Nov 21 19:26:44 UTC 2013


This makes apps permanent by default, and restricts text input fields to 254 max characters. To test:

1. Flash node and make it a gateway
2. Try to input more than 254 chars in any text field (should not work)
3. Try to input a port > 5 chars and a ttl > 2 chars (should not work)
4. Add an app with a description and name and icon URL of 254 chars, port = 80, and URL/ipaddr = http://google.com/12345678901234567890... (fill up max 254 chars). This should succeed.
5. Now edit this app, and uncheck the permanent box. Save the app.
6. Edit the app again, and the permanent checkbox should be unchecked.
You can merge this Pull Request by running:

  git pull https://github.com/opentechinstitute/luci-commotion-apps field-length

Or you can view, comment on it, or merge it online at:

  https://github.com/opentechinstitute/luci-commotion-apps/pull/36

-- Commit Summary --

  * added controls for keeping TXT fields and name field under 255 chars
  * apps permanent by default

-- File Changes --

    M lua/luci/controller/commotion/apps_controller.lua (10)
    M lua/luci/view/commotion/apps_form.htm (14)

-- Patch Links --

https://github.com/opentechinstitute/luci-commotion-apps/pull/36.patch
https://github.com/opentechinstitute/luci-commotion-apps/pull/36.diff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20131121/17809fe9/attachment.html>


More information about the Commotion-admin mailing list