[Commotion-admin] [luci-commotion] LuCI status pages trigger infinite redirect (#440)

[Josh King]

Now that I've gotten a chance to look at it, it looks like you were right @elationfoundation. The `crypto.check_https` function loops forever, though it isn't because it cuts out the wrong part of the string. It looks like the environment no longer passes an `HTTPS` element, which is how the function previously determined that the redirect completed. I can change it to a `env.SERVER_PORT ~= 443` check to 'fix' it, but that's kind of crappy. It's probably fine for our setup, but I don't like that it doesn't actually directly signal whether the handshake completed or not (if we were running HTTP on port 443 it would still complete). Not a big deal, but anyone have any better ideas about how to do that check?

---
Reply to this email directly or view it on GitHub:
https://github.com/opentechinstitute/luci-commotion/issues/440#issuecomment-66521749
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20141210/fadde8e1/attachment.html>