[Commotion-admin] [mlab-observatory] Changing semantics of ObservatoryFileWriter so that the caller does not ... (#35)

[Collin Anderson]

>      for date, values in hourly_items:
>        values['month'] = date.month
>        values['hour'] = date.hour
>        values['year'] = date.year
> -    fields = ['month', 'hour', 'year',]
> -    fields.extend(self._metric_field_names)
> +      for field_name in sorted(values.keys()):

Why not have this be a set and simply take the union of field and values keys?

---
Reply to this email directly or view it on GitHub:
https://github.com/opentechinstitute/mlab-observatory/pull/35/files#r22615737
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.chambana.net/pipermail/commotion-admin/attachments/20150107/f48bb485/attachment.html>